10 Aug
2020
10 Aug
'20
4:14 p.m.
Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44084 )
Change subject: soc/intel/common/block/gspi: Recalculate BAR after resource allocation ......................................................................
Patch Set 4:
(1 comment)
Added comment, please take another look.
https://review.coreboot.org/c/coreboot/+/44084/2/src/soc/intel/common/block/... File src/soc/intel/common/block/gspi/gspi.c:
https://review.coreboot.org/c/coreboot/+/44084/2/src/soc/intel/common/block/... PS2, Line 260:
I think it would be very helpful to have a comment here explaining why the stashed values are being […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/44084
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81f2b5bfadbf1aaa3b38cca2bcc44ce521666821
Gerrit-Change-Number: 44084
Gerrit-PatchSet: 4
Gerrit-Owner: Jes Klinke jbk@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jes Klinke jbk@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 10 Aug 2020 16:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment