Attention is currently required from: John Zhao, Duncan Laurie, Brandon Breitenstein, Rajmohan Mani.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49257 )
Change subject: ec/google/chromeec: Provide EC access for Retimer firmware update
......................................................................
Patch Set 5:
(1 comment)
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/49257/comment/b30e9378_17e27173
PS4, Line 242: \_SB_.PCI0.LPCB.EC0_.
Got it. The desired path is _SB.PCI0.LPCB.EC0.RFWU. But the chromeec has path _SB.PCI0.LPCB.EC0. […]
You're right, I have been meaning to deal with the whole EC0.CREC thing and haven't had a chance to fix it yet.
until we have separate EC0 & CREC devices in the devicetree, I see two solutions, both are hacks:
1) get to the ec_dev's parent device, e.g., `dev->bus->dev` or
2) just hardcode the entire path as a string like in this patch
I slightly prefer 1, WDYT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49257
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3817d93cfdeedf15825dab6c537b151fd063338b
Gerrit-Change-Number: 49257
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Attention: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Attention: Duncan Laurie
dlaurie@chromium.org
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Comment-Date: Fri, 15 Jan 2021 23:49:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao
john.zhao@intel.corp-partner.google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment