[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Change HDMI DDC GPIOs to native function

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43294 )

Change subject: mb/google/dedede: Change HDMI DDC GPIOs to native function
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43294/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43294/2//COMMIT_MSG@11 
PS2, Line 11: FSP doesn't configure these GPIOs properly
> Was that observed in practice? Is that an FSP bug?

No Paul, it was issue of coreboot. Ideally coreboot owns gpio programming for the board.

https://review.coreboot.org/c/coreboot/+/43294/2//COMMIT_MSG@9 
PS2, Line 9: HDMI DDC gpios were configured as NC till now in waddledoo.
           : This may cause HDMI i2c transfer to break and EDID read may fail if
           : FSP doesn't configure these GPIOs properly.
> Please re-flow for 75 characters per line.

Done