[coreboot-gerrit] [L] Change in coreboot[main]: mb/asrock: Add Z87 Extreme4 (Haswell)

[Jan Philipp Groß (Code Review)]

Attention is currently required from: Angel Pons, Nicholas Chin.

Jan Philipp Groß has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/84672?usp=email )

Change subject: mb/asrock: Add Z87 Extreme4 (Haswell)
......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84672/comment/0b01d33b_0fe61982?usp... :
PS1, Line 50: resulting in the wrong
            : fan being controlled.
> For the HWM, you may need to set `irq 0x30 = 0xe1`. […]

Isn't that set in the devicetree.cb already?

File src/mainboard/asrock/z87_extreme4/Kconfig:

https://review.coreboot.org/c/coreboot/+/84672/comment/16ca5a41_ae05a0be?usp... :
PS1, Line 28: config USBDEBUG_HCD_INDEX # FIXME: check this
            : 	int
            : 	default 2
> Yes. […]

I got no match in any of the tested USB ports. I've tried with a USB mouse and a USB-2.0-Stick. Maybe one of the three USB-2.0-Headers would give off a signal, but I have no way of testing them. 😞