Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43881 )
Change subject: mb/google/fizz: Relocate devicetree FSP settings ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43881/2/src/mainboard/google/fizz/v... File src/mainboard/google/fizz/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43881/2/src/mainboard/google/fizz/v... PS2, Line 270: device pci 15.1 off end # I2C #1 1) So, this is off here in the devtree.
https://review.coreboot.org/c/coreboot/+/43881/2/src/mainboard/google/fizz/v... File src/mainboard/google/fizz/variants/endeavour/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43881/2/src/mainboard/google/fizz/v... PS2, Line 63: register "i2c_voltage[1]" = "I2C_VOLTAGE_3V3" 3) This setting was right here from the start. Why? What for?
https://review.coreboot.org/c/coreboot/+/43881/2/src/mainboard/google/fizz/v... PS2, Line 91: device pci 15.1 off # I2C #1: TPM 2) By inheritance, it is off here as well. Adding it doesn't change the binary.