Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Chris Wang, Tim Van Patten, Fred Reitberger, Karthikeyan Ramasubramanian, Felix Held.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68469 )
Change subject: soc/amd/mendocino: Expand extra 5 DPTC thermal related profiles
......................................................................
Patch Set 8:
(1 comment)
File src/soc/amd/mendocino/chip.h:
https://review.coreboot.org/c/coreboot/+/68469/comment/5fead937_9162b7ed
PS4, Line 77: uint32_t sustained_power_limit_mW_B;
: uint32_t fast_ppt_limit_mW_B;
: uint32_t slow_ppt_limit_mW_B;
: uint32_t slow_ppt_time_constant_s_B;
: uint32_t thermctl_limit_degreeC_B;
Let's reduce the change to only what's necessary, meaning only the settings that are actually changi […]
Hi Tim,
As thermal's feedback b/248086651#comment14, those settings are needed.
Please help to reply thermal team on b/248086651 and I can follow your final
design to modify changes.
BR,
Eric KY Cheng
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie03de155325cbb340fce09848327ff7fa33ab1fd
Gerrit-Change-Number: 68469
Gerrit-PatchSet: 8
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 25 Oct 2022 03:15:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment