21 Mar
2018
21 Mar
'18
6:11 p.m.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/25306 )
Change subject: util/ifdtool: Fix region access control for SKL/KBL ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/25306/1/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/#/c/25306/1/util/ifdtool/ifdtool.c@829 PS1, Line 829: PLATFORM_SKLKBL How about putting different entries as below for SKL and KBL considering different variants like SKL-U, SKL-Y, KBL-U and KBL-Y.
case PLATFORM_SKL: case PLATFORM_KBL:
--
To view, visit https://review.coreboot.org/25306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1328d8006c25be282b3223268d8f1fd0a64e2ed3
Gerrit-Change-Number: 25306
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Wed, 21 Mar 2018 18:11:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No