build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48800 )
Change subject: soc/intel/apl: move UART pad config to boards ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48800/9/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/48800/9/src/mainboard/google/octopu... PS9, Line 297: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_64, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART2_RXD */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/48800/9/src/mainboard/google/octopu... PS9, Line 298: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_65, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART2_TXD */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/48800/9/src/mainboard/intel/glkrvp/... File src/mainboard/intel/glkrvp/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/48800/9/src/mainboard/intel/glkrvp/... PS9, Line 240: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_64, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD),/*LPSS_UART2_RXD*/ line over 96 characters
https://review.coreboot.org/c/coreboot/+/48800/9/src/mainboard/intel/glkrvp/... PS9, Line 241: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_65, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD),/*LPSS_UART2_TXD*/ line over 96 characters