Attention is currently required from: Tarun Tuli, Kapil Porwal, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69680 )
Change subject: soc/intel/meteorlake: Skip setting D0I3 bit for HECI devices
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69680/comment/d8e3139b_513fe848
PS1, Line 9: This patch skips setting D0I3 bit for all HECI devices by FSP.
it's a backport ?
The original CL don't indicate why the change has done.
I hope you still have access to the https://b.corp.google.com/issues/200644229 (from original CL) which intended to fix the `super weird issue about CSE` aka Intel CSE EOP implementation is taking longer time (sometime ~60ms), average ~30ms bug.
Do you want to put that in the commit msg ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69680
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c3765ce41f192ab5f5ff176e0a2b49b312d18d2
Gerrit-Change-Number: 69680
Gerrit-PatchSet: 1
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 09:59:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment