Attention is currently required from: Balázs Vinarz, Elyes Haouas, Vlado Ilic.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79838?usp=email )
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Sorry, but by doing this "git checkout 5e8e911" etc. - you will lose at least 5 thousands of new coreboot commits, including all the improvements to the common coreboot source code that has been done since 5e8e911. Therefore, I had to introduce this new way: these git reverts help us to stay as close as possible to coreboot master and enjoy its new improvements - instead of being forever stuck at 5e8e911
This is really ugly & not easy to review
I agree that it may look ugly, however this whole commit is super easy: just a bunch of git reverts, not much room for mistake there ;-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79838?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Gerrit-Change-Number: 79838
Gerrit-PatchSet: 6
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alexander Goncharov
chat@joursoir.net
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Vlado Ilic
kakonema@gmail.com
Gerrit-CC: awokd@danwin1210.me
Gerrit-Attention: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Attention: Vlado Ilic
kakonema@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 22 Feb 2024 10:02:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment