Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48317 )
Change subject: soc/amd/cezanne: add config.c and minimal chip.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48317/1/src/soc/amd/cezanne/config.... File src/soc/amd/cezanne/config.c:
https://review.coreboot.org/c/coreboot/+/48317/1/src/soc/amd/cezanne/config.... PS1, Line 9: cfg
It looks like the soc_get_config() return value is typically checked for non-0. […]
cfg is always non-NULL, so no need to re-check that here: config_of_soc calls config_of which calls die() if either dev or dev->chip_info are NULL. I can add a comment about that to make that a bit clearer. What I do wonder though is is I should add a check if cfg->common_config is non-NULL and call die("common_config missing in SoC config!") if it is NULL