[coreboot-gerrit] Change in coreboot[master]: hatch: refactor gpio table into baseboard, allow empty SPDs

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36068 )

Change subject: hatch: refactor gpio table into baseboard, allow empty SPDs
......................................................................

hatch: refactor gpio table into baseboard, allow empty SPDs

Each variant needed to define variant_early_gpio_table(), even if
it didn't need to make any changes. Added a __weak version of the
function into baseboard/gpio.c.

Certain upcoming Hatch variants will not use SPD files. Allow
SPD_SOURCES in spd/Makefile.inc to be empty.

BUG=None
BRANCH=None
TEST=Build coreboot and see that it builds without error

Change-Id: Ie946cfd7c071824168faa38fd53bd338a5a451e1
Signed-off-by: Paul Fagerburg 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36068
Reviewed-by: Furquan Shaikh 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/hatch/spd/Makefile.inc
M src/mainboard/google/hatch/variants/baseboard/gpio.c
2 files changed, 10 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/spd/Makefile.inc b/src/mainboard/google/hatch/spd/Makefile.inc
index 9ab7394..97a4dfd 100644
--- a/src/mainboard/google/hatch/spd/Makefile.inc
+++ b/src/mainboard/google/hatch/spd/Makefile.inc
@@ -13,13 +13,10 @@
 ## GNU General Public License for more details.
 ##

+ifneq ($(SPD_SOURCES),)
 SPD_BIN = $(obj)/spd.bin

-ifeq ($(SPD_SOURCES),)
-	SPD_DEPS := $(error SPD_SOURCES is not set. Variant must provide this)
-else
-	SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)
-endif
+SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)

# Include spd ROM data
 $(SPD_BIN): $(SPD_DEPS)
@@ -32,3 +29,4 @@
 cbfs-files-y += spd.bin
 spd.bin-file := $(SPD_BIN)
 spd.bin-type := spd
+endif
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c
index f8df447..598600b 100644
--- a/src/mainboard/google/hatch/variants/baseboard/gpio.c
+++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c
@@ -443,3 +443,10 @@
    *num = 0;
    return NULL;
 }
+
+/* Weak implementation of early gpio */
+const struct pad_config *__weak variant_early_gpio_table(size_t *num)
+{
+	*num = 0;
+	return NULL;
+}