Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39147 )
Change subject: soc/intel/{icl,tgl}: Make use of print_me_fw_version() from CSE lib
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39147/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39147/5//COMMIT_MSG@14
PS5, Line 14: TEST=Build and boot iclrvp, tglrvp boards.
I see that you have included these files in a Makefile in the subsequent patch, you have to do that […]
Yes, has been tested with both patches together.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief75403c490eee499a84372e54fa38ea3016cc11
Gerrit-Change-Number: 39147
Gerrit-PatchSet: 6
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Mar 2020 10:56:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-MessageType: comment