Attention is currently required from: Eric Herrmann, Shelley Chen.
Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83406?usp=email )
Change subject: mb/google/brox: Reduce PL values for booting without battery
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I am making sure that these values work on both SKU1 and SKU2 proto-2 boards for 65Watts and 45Watts charger(for SKU1) consistently on few boards in the lab.
I will address review comments shortly after confirming that this a proper fix without regression
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83406?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0074bfc97c54f07d0b7257393de7c355e36b262
Gerrit-Change-Number: 83406
Gerrit-PatchSet: 2
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Eric Herrmann
eherrmann@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eric Herrmann
eherrmann@google.com
Gerrit-Comment-Date: Mon, 15 Jul 2024 06:38:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No