Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31567 )
Change subject: soc/cavium/cn81xx: Enable RNG for DRAM init
......................................................................
Patch Set 1:
(2 comments)
So DRAM init didn’t work before?
https://review.coreboot.org/#/c/31567/1/src/soc/cavium/cn81xx/sdram.c
File src/soc/cavium/cn81xx/sdram.c:
https://review.coreboot.org/#/c/31567/1/src/soc/cavium/cn81xx/sdram.c@67
PS1, Line 67: /**
Just one asterisk?
https://review.coreboot.org/#/c/31567/1/src/soc/cavium/cn81xx/sdram.c@76
PS1, Line 76: /* Errata (RNM-22528) First consecutive reads to RNM_RANDOM return same
Please use the allowed comment style for concise comments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31567
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I886f920e9941793fb76b56cc5a24a42e23b082e0
Gerrit-Change-Number: 31567
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks
dhendrix.sync@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 22 Feb 2019 14:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment