Deepika Punyamurtula has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43528 )
Change subject: mb/google/volteer: Update DPTF with temp sensor 3
......................................................................
Patch Set 2: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/43528/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43528/2/src/mainboard/google/voltee...
PS2, Line 323: register "policies.passive[1]" = "DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 60000)"
Yeah, if the values are in milliseconds looks like these should be reduced by a factor of 10
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43528
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71bc798492ec45bb1e2f8d779e6829db52ef4499
Gerrit-Change-Number: 43528
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Deepika Punyamurtula
deepika.punyamurtula@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 17 Jul 2020 02:22:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment