build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44582 )
Change subject: tint: introduce the new tint build system with checksum verification ......................................................................
Patch Set 4:
(7 comments)
https://review.coreboot.org/c/coreboot/+/44582/4/payloads/external/tint/gene... File payloads/external/tint/generate_core.sh:
https://review.coreboot.org/c/coreboot/+/44582/4/payloads/external/tint/gene... PS4, Line 40: sed -n "/^${start}/,/^${end}/{/^${start}/{p;n};/^${end}/{q};{p}}" "$source" >> "$destination" line over 96 characters
https://review.coreboot.org/c/coreboot/+/44582/4/payloads/external/tint/gene... PS4, Line 54: FUNCTIONS="please_install searchtool download compute_hash error_hash_mismatch verify_hash unpack_and_patch" line over 96 characters
https://review.coreboot.org/c/coreboot/+/44582/4/payloads/external/tint/gene... PS4, Line 64: import_from_file "$buildgcc" "$corescript" "# Find all the required tools" "# Allow" "last_line_disabled" || exit "$?" line over 96 characters
https://review.coreboot.org/c/coreboot/+/44582/4/payloads/external/tint/gene... PS4, Line 99: sed -i -e "/$TAR $FLAGS "$(basename "$archive")"/a prepare_${package} || exit "$?"" "$corescript" line over 96 characters
https://review.coreboot.org/c/coreboot/+/44582/4/payloads/external/tint/tint... File payloads/external/tint/tintify_core.sh:
https://review.coreboot.org/c/coreboot/+/44582/4/payloads/external/tint/tint... PS4, Line 55: echo "rm -rf ./${TINT_DIR}/debian ./${TINT_DIR}/typedefs.h ./${TINT_DIR}/Makefile;" >> "$tintified" line over 96 characters
https://review.coreboot.org/c/coreboot/+/44582/4/payloads/external/tint/tint... PS4, Line 70: sed -i -e "/download() {/a package=$1\narchive_link="$(eval echo \\$$package"_ARCHIVE_LINK")"" "$tintified" line over 96 characters
https://review.coreboot.org/c/coreboot/+/44582/4/payloads/external/tint/tint... PS4, Line 72: sed -i -e "s/(download_showing_percentage "$archive)./\1_link"\nreplace_plus_with_minus/g" "$tintified" line over 96 characters