[coreboot-gerrit] [XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6316 driver

[Jarried Lin (Code Review)]

Attention is currently required from: Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85630?usp=email )

Change subject: soc/mediatek/mt8196: Add PMIC MT6316 driver
......................................................................

Patch Set 9:

(8 comments)

File src/soc/mediatek/common/mt6316.c:

https://review.coreboot.org/c/coreboot/+/85630/comment/dc0b81f5_7966e601?usp... :
PS7, Line 48: 0x%x
> %#x

Done

https://review.coreboot.org/c/coreboot/+/85630/comment/9149de5a_d96541ec?usp... :
PS7, Line 78: %u
> `%u\n`

Done

https://review.coreboot.org/c/coreboot/+/85630/comment/5d9e04d2_4c3296eb?usp... :
PS7, Line 106: %u
> \n

Done

https://review.coreboot.org/c/coreboot/+/85630/comment/e0a59694_f50f8ed0?usp... :
PS7, Line 132: %u
> `%u\n`

Done

https://review.coreboot.org/c/coreboot/+/85630/comment/1f211c1c_751e6340?usp... :
PS7, Line 158: -1
> false

Done

https://review.coreboot.org/c/coreboot/+/85630/comment/9984889a_7e12e6df?usp... :
PS7, Line 170: {
> remove

Done

https://review.coreboot.org/c/coreboot/+/85630/comment/4231afe0_30850975?usp... :
PS7, Line 184: 
             : 	printk(BIOS_INFO, "[%s][MT6316_6]CHIP ID =  0x%x\n", __func__,
             : 	       mt6316_read_field(SPMI_SLAVE_6, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0));
             : 	printk(BIOS_INFO, "[%s][MT6316_7]CHIP ID =  0x%x\n", __func__,
             : 	       mt6316_read_field(SPMI_SLAVE_7, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0));
             : 	printk(BIOS_INFO, "[%s][MT6316_8]CHIP ID =  0x%x\n", __func__,
             : 	       mt6316_read_field(SPMI_SLAVE_8, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0));
             : 	printk(BIOS_INFO, "[%s][MT6316_15]CHIP ID =  0x%x\n", __func__,
             : 	       mt6316_read_field(SPMI_SLAVE_15, MT6316_PMIC_SWCID_H_ADDR, 0xFF, 0x0));
>

Done

https://review.coreboot.org/c/coreboot/+/85630/comment/8cb4af4e_7707ea7f?usp... :
PS7, Line 199: {
> remove

Done