Attention is currently required from: Angel Pons, Felix Singer, Mario Scheithauer, Paul Menzel, Werner Zeh.
Hello Angel Pons, Felix Singer, Mario Scheithauer, Werner Zeh, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75500?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed: Code-Review+1 by Felix Singer, Verified+1 by build bot (Jenkins)
Change subject: drv/i2c/pi608gp: Fix types ......................................................................
drv/i2c/pi608gp: Fix types
In commit e59f18bf29a8 ("drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)"), there were some suggestions after it's been already merged.
This patch addresses the points regarding the number types - fix of the printk format strings, inclusion of 'stdint.h' and marking the set of allowed values as constant.
BUG=none TEST=Build OK, no behavioral changes in the pi608gp driver, console logs without changes.
Change-Id: I34c664f6a8a257b260facdbf9043825ff4a4c932 Signed-off-by: Jan Samek jan.samek@siemens.com --- M src/drivers/i2c/pi608gp/pi608gp.c M src/drivers/i2c/pi608gp/pi608gp.h 2 files changed, 7 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/75500/6