Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33484 )
Change subject: mainboard/facebook/fbg1701: Add FMAP file ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33484/1/src/mainboard/facebook/fbg1701/Kconf... File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/#/c/33484/1/src/mainboard/facebook/fbg1701/Kconf... PS1, Line 57: 0x00800000
Set this to 0x600000 and the default fmap will be very similar
Will change it to 0x5F700 which is CBFS size with 4K alignment for MRC cache.
https://review.coreboot.org/#/c/33484/1/src/mainboard/facebook/fbg1701/fmap.... File src/mainboard/facebook/fbg1701/fmap.fmd:
https://review.coreboot.org/#/c/33484/1/src/mainboard/facebook/fbg1701/fmap.... PS1, Line 17: RW_MRC_CACHE@0x200 0x8000
should be 64K aligned iirc.
Expect the alignment is related to SPI layout/routines. If SPI routines update the modified bytes only and saves bytes in same block(s), there is not issue. Will align to 4K which is sector size of used SPI.