11 Aug
2020
11 Aug
'20
6:45 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43960 )
Change subject: soc/mediatek/mt8192: Add spi driver ......................................................................
Patch Set 6: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43960/6/src/soc/mediatek/mt8192/spi... File src/soc/mediatek/mt8192/spi.c:
https://review.coreboot.org/c/coreboot/+/43960/6/src/soc/mediatek/mt8192/spi... PS6, Line 106: assert(pad_select == SPI_PAD0_MASK); Sorry, one more question. Is this function going to support other pad_select value in the future?
--
To view, visit https://review.coreboot.org/c/coreboot/+/43960
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2094dd2f14ad19b7dbd66a8e694cc71d654a2b4b
Gerrit-Change-Number: 43960
Gerrit-PatchSet: 6
Gerrit-Owner: CK HU ck.hu@mediatek.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: wang qii Qii.Wang@mediatek.com
Gerrit-Comment-Date: Tue, 11 Aug 2020 06:45:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment