Attention is currently required from: Caveh Jalali, Forest Mittelberg.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83639?usp=email )
Change subject: ec/google/chromeec: Drop 'choice' selections for EC and PD firmware ......................................................................
ec/google/chromeec: Drop 'choice' selections for EC and PD firmware
Since the EC and PD firmware sources are now limited to two options - 'none' and 'external' - drop the choice selection and make the EC and PD external options independent.
TEST=build google/lulu with external EC binary using existing defconfig
Change-Id: Ie37ff3a188b414fd099fbb344858bca4df419086 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/ec/google/chromeec/Kconfig 1 file changed, 6 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/83639/1
diff --git a/src/ec/google/chromeec/Kconfig b/src/ec/google/chromeec/Kconfig index e8a5d58..7a8777f 100644 --- a/src/ec/google/chromeec/Kconfig +++ b/src/ec/google/chromeec/Kconfig @@ -110,22 +110,10 @@ Enable support for the real-time clock on the ChromeOS EC. This uses the EC_CMD_RTC_GET_VALUE command to read the current time.
-choice - prompt "Chrome EC firmware source" - default EC_GOOGLE_CHROMEEC_FIRMWARE_NONE - - config EC_GOOGLE_CHROMEEC_FIRMWARE_NONE - bool "No EC firmware is included" +config EC_GOOGLE_CHROMEEC_FIRMWARE_EXTERNAL + bool "Include an external EC firmware binary" help - No EC firmware is included in the image. - - config EC_GOOGLE_CHROMEEC_FIRMWARE_EXTERNAL - bool "External EC firmware is included" - help - Include EC firmware binary in the image from an external source. - It is expected to be built externally. - -endchoice + Include a precompiled EC firmware binary in the image.
config EC_GOOGLE_CHROMEEC_FIRMWARE_FILE string "Chrome EC firmware path and filename" @@ -133,23 +121,11 @@ help The path and filename of the EC firmware file to use.
-choice - prompt "Chrome EC firmware source for PD" +config EC_GOOGLE_CHROMEEC_PD_FIRMWARE_EXTERNAL + bool "Include an external PD firmware binary" depends on EC_GOOGLE_CHROMEEC_PD - default EC_GOOGLE_CHROMEEC_PD_FIRMWARE_NONE - - config EC_GOOGLE_CHROMEEC_PD_FIRMWARE_NONE - bool "No PD firmware is included" help - No PD firmware is included in the image. - - config EC_GOOGLE_CHROMEEC_PD_FIRMWARE_EXTERNAL - bool "External PD firmware is included" - help - Include PD firmware binary in the image from an external source. - It is expected to be built externally. - -endchoice + Include a precompiled PD firmware binary in the image.
config EC_GOOGLE_CHROMEEC_PD_FIRMWARE_FILE string "Chrome EC firmware path and filename for PD"