Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36518 )
Change subject: trogdor: QCSDI loading depends on VB2_GBB_FLAG_RUNNING_FAFT setting flag
......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36518/28/src/soc/qualcomm/common/qc...
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/36518/28/src/soc/qualcomm/common/qc...
PS28, Line 130: struct vb2_context *ctx = vboot_get_context();
This still fails when CONFIG(VBOOT) is disabled. Remove the variable and actually write
CONFIG(VBOOT) && (!(vb2api_gbb_get_flags(vboot_get_context()) & VB2_GBB_FLAG_RUNNING_FAFT)
below
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63f35c94bc6c60934ace5fe0fd9176443059b354
Gerrit-Change-Number: 36518
Gerrit-PatchSet: 28
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: ashk@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 11 Feb 2020 05:59:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment