[coreboot-gerrit] Change in coreboot[master]: util: Add spd_tools to generate DDR4 SPDs for TGL boards

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44429 )

Change subject: util: Add spd_tools to generate DDR4 SPDs for TGL boards
......................................................................

Patch Set 29: -Code-Review

(1 comment)

https://review.coreboot.org/c/coreboot/+/44429/29/util/spd_tools/intel/ddr4/... 
File util/spd_tools/intel/ddr4/gen_spd.go:

https://review.coreboot.org/c/coreboot/+/44429/29/util/spd_tools/intel/ddr4/... 
PS29, Line 192: 	return bg << 6
> I don't think this is right. 2 bank groups = 1 << 6, 4 bank groups = 2 << 6.

That's right!