[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Add MT6685 adc init

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85734?usp=email )

Change subject: soc/mediatek/mt8196: Add MT6685 adc init
......................................................................

Patch Set 3: Code-Review+1

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85734/comment/f239ca32_4c9628e8?usp... :
PS3, Line 7: adc
We don't use ADC function on MT6685 and this patch does not implement ADC function, too.

File src/soc/mediatek/common/mt6685.c:

https://review.coreboot.org/c/coreboot/+/85734/comment/197b69f2_ca4c1475?usp... :
PS3, Line 10: define MT6685_SLAVE_ID			0x9
remove

https://review.coreboot.org/c/coreboot/+/85734/comment/9024633f_b6146e5e?usp... :
PS3, Line 31: MT6685_SLAVE_ID
SPMI_SLAVE_9

https://review.coreboot.org/c/coreboot/+/85734/comment/f6fdbfeb_7d2f48d2?usp... :
PS3, Line 59: 	wdata = mt6685_read_field(MT6685_TOP_RST_MISC, 0xFFFF, 0);
            : 	printk(BIOS_INFO, "[%s]MT6685 TOP_RST_MISC = %#x\n", __func__, wdata);
Why do we need to print the register content before setting ?

https://review.coreboot.org/c/coreboot/+/85734/comment/48f9e992_465b1755?usp... :
PS3, Line 81: "[mt6685]CHIP ID = %#x\n", mt6685_read_field(0xb, 0xFF, 0)
"[%s][MT6685]CHIP ID = %#x\n", __func__, mt6685_read_field(0xb, 0xFF, 0)