Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58772 )
Change subject: amd/hda: Remove the weak function
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
hm, here i would introduce a kconfig option SOC_AMD_COMMON_BLOCK_HDA_HAS_SOC_QUIRKS and only call hda_soc_ssdt_quirks when that option is set and then set that option in the stoneyridge Konfig. that would avoid having to add an empty function for quirks that are only needed on one SoC family to all SoC code. for the i2c thing the situation was different and there the additional function is only empty on stoneyridge, but needed on all other platforms
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b089b9fe4742b29686198f20fc7c1a2dae6f015
Gerrit-Change-Number: 58772
Gerrit-PatchSet: 10
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 30 Nov 2021 13:57:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment