Tristan Corrick has uploaded a new change for review. ( https://review.coreboot.org/19652 )
Change subject: nb/intel/gm45: Fix raminit with mixed raw card types ......................................................................
nb/intel/gm45: Fix raminit with mixed raw card types
`cardF[n]` should indicate whether the DIMM in channel n is of raw card type F. However, `cardF[1]` was initialised with the value meant for `cardF[0]`. This patch results in the correct initialisation of `cardF`.
Tested on a Lenovo T400 containing two DIMMs: one of raw card type F and the other of raw card type B. Before the patch, the system would not boot. After the patch, the system boots with all of the memory functional.
Change-Id: I7409df0b8c67d7efbdadae39dc718c8df7a92552 Signed-off-by: Tristan Corrick tristancorrick86@gmail.com --- M src/northbridge/intel/gm45/raminit_receive_enable_calibration.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/19652/1
diff --git a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c index c5614e1..7d57a4e 100644 --- a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c +++ b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c @@ -211,7 +211,7 @@
const int cardF[] = { dimms[0].card_type == 0xf, - dimms[0].card_type == 0xf, + dimms[1].card_type == 0xf, };
const unsigned int t_bound =