Attention is currently required from: Raul Rangel, Paul Menzel, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56499 )
Change subject: mb/google/guybrush: Update GPIOs for fingerprint MCU ......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56499/comment/768a1377_31b7299d PS2, Line 7: fingerprint
fingerprint sensor?
Updated to fingerprint MCU (microcontroller unit) The sensor is actually a different part, attached to the MCU.
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/56499/comment/38204bf1_bde0eb06 PS1, Line 388: mdelay
Let's check with the fingerprint team. I doubt we really need exactly 3ms delay. […]
3ms delay was eliminated.
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/56499/comment/0db004e8_16795fa8 PS2, Line 374: /* FPMCU_RST_L */ : PAD_NC(GPIO_11), : /* EN_PWR_FP */ : PAD_NC(GPIO_32),
One indentation level too much?
Done