[coreboot-gerrit] Change in coreboot[master]: {soc,vc,mb}/intel: Remove support for Cannon Lake SoC

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48775 )

Change subject: {soc,vc,mb}/intel: Remove support for Cannon Lake SoC
......................................................................

Patch Set 4:

(4 comments)

https://review.coreboot.org/c/coreboot/+/48775/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48775/3//COMMIT_MSG@9 
PS3, Line 9: Soc
> nit: SoC

Done

https://review.coreboot.org/c/coreboot/+/48775/3//COMMIT_MSG@11 
PS3, Line 11: intel/cannonlake_rvp and its FSP headers in intel/fsp2_0/cannonlake.
> FSP binaries for CNL were never released publicly, were they? If so, then it's a pretty good reason  […]

Thanks Angel!

https://review.coreboot.org/c/coreboot/+/48775/3/src/soc/intel/cannonlake/Kc... 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/c/coreboot/+/48775/3/src/soc/intel/cannonlake/Kc... 
PS3, Line 4: config SOC_INTEL_CANNONLAKE_ALTERNATE_HEADERS
> There is only one default left. Please remove it too and all references to it.

Done

https://review.coreboot.org/c/coreboot/+/48775/3/src/soc/intel/cannonlake/Kc... 
PS3, Line 85: 	select HECI_DISABLE_USING_SMM if !SOC_INTEL_COFFEELAKE && !SOC_INTEL_WHISKEYLAKE && !SOC_INTEL_COMETLAKE
> Looks dead too.

Done