Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58180 )
Change subject: mb/google/brya: Clear SLP_S0_GATE_L on ACPI sleep entry
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/google/brya/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/58180/comment/0b79693a_b807797d
PS1, Line 30: S5 shutdown
On entry of S1-S5 yes. _PTS is not called for s2idle cases (ACPI has different s2idle vs. […]
Ack.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58180
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5500e701ac8731d141b51dc381609c80047dc1f8
Gerrit-Change-Number: 58180
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Boris Mittelberg
bmbm@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 07 Oct 2021 19:05:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment