27 Aug
2020
27 Aug
'20
3:52 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44774 )
Change subject: mb: remove duplicated Make code for spd.bin generation ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44774/4/src/mainboard/bap/ode_e20XX... File src/mainboard/bap/ode_e20XX/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44774/4/src/mainboard/bap/ode_e20XX... PS4, Line 19: SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.hex) The generic version expects files to be in a spd/ subdir. How does it work at all? I'm confused.
--
To view, visit https://review.coreboot.org/c/coreboot/+/44774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd3ac0fd6c901228554115c6350d88bb49874587
Gerrit-Change-Number: 44774
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian david.guckian@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 27 Aug 2020 13:52:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment