Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31283 )
Change subject: mb/intel/coffeelake_rvp: Add cml_u board support
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/31283/5/src/mainboard/intel/coffeelake_rvp/K...
File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/#/c/31283/5/src/mainboard/intel/coffeelake_rvp/K...
PS5, Line 1: BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVPU || BOARD_INTEL_WHISKEYLAKE_RVP || BOARD_INTEL_COFFEELAKE_RVP8 || BOARD_INTEL_COMETLAKE_RVP
It might be easier to just do something like […]
Yes Furquan, I'll look into that, since we may need to add BOARD_INTEL_COFFEELAKE_RVP somewhere outside board's Kconfig. Adding it in Kconfig.name will expose it in menuconfig, so we may need to check for appropriate file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31283
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f81b47f33345edefa0a7064559d9531e1d20eff
Gerrit-Change-Number: 31283
Gerrit-PatchSet: 6
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 23 Feb 2019 02:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment