Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47483 )
Change subject: [WIP] soc/amd/common: factor out SMU code from Picasso
......................................................................
Patch Set 2: Code-Review-1
The SMU code here may work on Picasso, and may work on Renoir. However, it is not common to the AM4 CPUs. Matisse, for example, has different values for the REG_ADDR_* constants and also supports 8 arguments instead of 6.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47483
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibaf5b91ab35428e4c771e7163c6e0c4fc50371e7
Gerrit-Change-Number: 47483
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Nov 2020 15:41:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment