Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51073 )
Change subject: soc/amd/cezanne/acpi: Add globalnvs.asl ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: Is it possible a patch got in out of order? I'm getting an error that cbfstool can't find build/dsdt.aml, and I bisected to this change. If I scroll up a little bit:
Intel ACPI Component Architecture ASL+ Optimizing Compiler/Disassembler version 20190703 Copyright (c) 2000 - 2019 Intel Corporation
coreboot toolchain v40f539f8c4 2020-01-03 dsdt.asl 207: Field (GNVS, ByteAcc, NoLock, Preserve) Error 6142 - ^ Illegal forward reference (GNVS)
ASL Input: dsdt.asl - 18127 bytes 677 keywords 703 source lines
Compilation failed. 1 Errors, 0 Warnings, 0 Remarks No AML files were generated due to compiler error(s) IASL 3150 2158 warning types were ignored! IASL build/dsdt.aml disassembled correctly.