Attention is currently required from: Tim Wawrzynczak, Kyösti Mälkki.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58896 )
Change subject: ChromeOS: Add legacy mainboard_ec_running_ro()
......................................................................
Patch Set 14: Code-Review+2
(1 comment)
Patchset:
PS14:
I had a followup prepared already, I can squash these together […]
Yeah I mean you're just adding a bunch of code in this patch now that you're removing again in the next one, I think squashing would make sense. But not that important as long as we end up where we want to end up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58896
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cb95268424dc27f8c1e26b3d34eff1a7b8eab7f
Gerrit-Change-Number: 58896
Gerrit-PatchSet: 14
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 02 Apr 2022 01:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment