Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36145 )
Change subject: arch/arm: Pass cbmem_top to ramstage via calling argument ......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36145/15/src/arch/arm/stages.c File src/arch/arm/stages.c:
https://review.coreboot.org/c/coreboot/+/36145/15/src/arch/arm/stages.c@36 PS15, Line 36: _cbmem_top_ptr = (uintptr_t)stage_arg; Wouldn't it be cleaner to pass the argument through to main() and handle it in there? Then you don't have to duplicate everything for every arch (and it would be easier for custom entrypoints to tie into it, too).
https://review.coreboot.org/c/coreboot/+/36145/15/src/soc/rockchip/common/cb... File src/soc/rockchip/common/cbmem.c:
https://review.coreboot.org/c/coreboot/+/36145/15/src/soc/rockchip/common/cb... PS15, Line 28: #if !CONFIG(RAMSTAGE_CBMEM_TOP_ARG) When would this ever happen?