12 Sep
2019
12 Sep
'19
1:57 a.m.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35226 )
Change subject: src/soc/intel/common/block/cse: Make hfsts1 common & add helper functions ......................................................................
Patch Set 21:
(1 comment)
Patch Set 20:
(2 comments)
It
https://review.coreboot.org/c/coreboot/+/35226/20/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35226/20/src/soc/intel/common/block... PS20, Line 247: cse_sec_override_mode
nit: check_cse_sec_override_mode? would communicate the function better. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/35226
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5c12b7abdb27c38af74ea6ee568b42ec74bcb3c
Gerrit-Change-Number: 35226
Gerrit-PatchSet: 21
Gerrit-Owner: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Sep 2019 08:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aamir Bohra aamir.bohra@intel.com
Gerrit-MessageType: comment