Attention is currently required from: HAOUAS Elyes.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45517 )
Change subject: nb/intel: Introduce MCHBAR accessor functions
......................................................................
Patch Set 41:
(2 comments)
File src/northbridge/intel/common/mchbar_ops.h:
https://review.coreboot.org/c/coreboot/+/45517/comment/5ecd842d_91e9387f
PS41, Line 39: #define mchbar16_and_or(offset, mask, value) _mchbar16_and_or((offset), (u16)(mask), (u16)(value))
line over 96 characters
https://review.coreboot.org/c/coreboot/+/45517/comment/5c3ab7d3_690a87ce
PS41, Line 51: #define mchbar32_and_or(offset, mask, value) _mchbar32_and_or((offset), (u32)(mask), (u32)(value))
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45517
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fa844a8a13a75d6d802ca48f72c513bfa16d0a5
Gerrit-Change-Number: 45517
Gerrit-PatchSet: 41
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 16 Jan 2021 21:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment