Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 24:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 20: # defaults to 0; datasheet says clkreq# isn't supported for root ports and this is RO; can we drop this then?
I don't want them to get merged; this is just a hint for review; this will get removed as soon as I […]
Done
https://review.coreboot.org/c/coreboot/+/35427/17/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35427/17/src/mainboard/supermicro/x... PS17, Line 22: #define X11SSM_F_PAD_DW0_DW1_CFG(val, config0, config1) \
I copied that from somewhere... but it' not really needed. […]
Done