Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )
Change subject: google/kukui: boot up sspm ......................................................................
Patch Set 4:
(8 comments)
https://review.coreboot.org/#/c/31516/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31516/4//COMMIT_MSG@7 PS4, Line 7: boot up sspm Boot up SSPM
https://review.coreboot.org/#/c/31516/4//COMMIT_MSG@9 PS4, Line 9: enables enable
https://review.coreboot.org/#/c/31516/4//COMMIT_MSG@14 PS4, Line 14: worng wrong
https://review.coreboot.org/#/c/31516/4/src/mainboard/google/kukui/Kconfig File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/#/c/31516/4/src/mainboard/google/kukui/Kconfig@7... PS4, Line 71: ---help--- That syntax seems new.
https://review.coreboot.org/#/c/31516/4/src/mainboard/google/kukui/Kconfig@7... PS4, Line 72: SSPM is Secure System Power Manager for power control in secure domain. Please add a dot at the end.
https://review.coreboot.org/#/c/31516/4/src/soc/mediatek/mt8183/sspm.c File src/soc/mediatek/mt8183/sspm.c:
https://review.coreboot.org/#/c/31516/4/src/soc/mediatek/mt8183/sspm.c@23 PS4, Line 23: void Make that bool?
https://review.coreboot.org/#/c/31516/4/src/soc/mediatek/mt8183/sspm.c@35 PS4, Line 35: printk(BIOS_DEBUG, "no sspm\n"); No SSPM firmware(?) found.
https://review.coreboot.org/#/c/31516/4/src/soc/mediatek/mt8183/sspm.c@35 PS4, Line 35: BIOS_DEBUG Make that INFO?