Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42830 )
Change subject: soc/amd/picasso: Add console & timestamp buffers to psp_verstage
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/memlayo...
File src/soc/amd/picasso/memlayout_psp_verstage.ld:
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/memlayo...
PS3, Line 57: vboot2_work
Do the console and timestamp regions have some kind of magic value we can use in bootblock to check if the regions were written by the PSP?
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/psp_ver...
File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/42830/3/src/soc/amd/picasso/psp_ver...
PS3, Line 155: _vboot2_work
Can you define a new region in the linker script: _workbuf and _eworkbuf. This will make it clearer that we are copying more than just vboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41c8d7a1565e761187e941d7d6021805a9744d06
Gerrit-Change-Number: 42830
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jul 2020 19:21:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment