2 Feb
2023
2 Feb
'23
11:47 p.m.
Attention is currently required from: Tim Crawford, Sean Rhodes, Jeremy Soller, Nick Vaccaro, Elyes Haouas.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72661 )
Change subject: treewide: Remove unuseful "_HID: Hardware ID" comment ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I do think these should be documented somewhere, but not every time they're used. […]
i agree that it would be better if the documentation explains those and with that i find it ok to drop the comments
--
To view, visit https://review.coreboot.org/c/coreboot/+/72661
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5eb1424e9e6c1fbf20cd0bf68fbb52e1ec97f905
Gerrit-Change-Number: 72661
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Crawford tcrawford@system76.com
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Jeremy Soller jeremy@system76.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 02 Feb 2023 23:47:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Crawford tcrawford@system76.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment