Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41712 )
Change subject: soc/intel/common: Add restore and enable GPIO PM
......................................................................
Patch Set 5:
Patch Set 5:
This patch can work on dedede and deltaur but you need remove board level hook. @Tim, I try the latest and still works fine at my side. Could you help review this?
Eric, we're hoping that we don't need to use the LPIT & the associated ACPI methods to enable/disable GPIO PM. We are working on a cr50 + coreboot solution that should fix it.
Do you think you need this soon?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41712
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5e4553d568a872de234a2d671118acbae0a6159
Gerrit-Change-Number: 41712
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jun 2020 17:14:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment