John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42839 )
Change subject: superio/nuvoton: Avoid NULL pointer dereference ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42839/3/src/superio/nuvoton/npcd378... File src/superio/nuvoton/npcd378/superio.c:
https://review.coreboot.org/c/coreboot/+/42839/3/src/superio/nuvoton/npcd378... PS3, Line 329: printk(BIOS_ERR, "Device scope does not exist.\n");
Error messages should be understandable by a “normal” user. […]
Done
https://review.coreboot.org/c/coreboot/+/42839/3/src/superio/nuvoton/npcd378... PS3, Line 410: {
How about adding the null check here?
It seems not relevant because there is already NULL check for scope in the function superio_common_fill_ssdt_generator. The scope NULL check is only applied to acpigen_write_scope call.