Attention is currently required from: Martin Roth, Mathew King.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50007 )
Change subject: mb/google/mi: Add mancomb baseboard
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS4:
Hi Kangheui, epeers said you may have some insight on what do with a box reference design. […]
AFAIK main complication for coreboot with box reference design is two things; you have two baseboards with very similar design so it'll end up with a lot of duplications and you can't use static SPD data for box design.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50007
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1264f44a0b986f7f7c89ac7b42f1e4e4119a35e6
Gerrit-Change-Number: 50007
Gerrit-PatchSet: 5
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Comment-Date: Thu, 28 Jan 2021 21:32:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Gerrit-MessageType: comment