Attention is currently required from: Dinesh Gehlot, Dolan Liu, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81774?usp=email )
Change subject: mb/google/nissa/var/anraggar: Add cbj_sleeve to control mic jack
......................................................................
Patch Set 19:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81774/comment/3dda46ab_389b2c76 :
PS18, Line 7: Add cbj_sleeve to control mic jack
:
Also mention that you replace the generic driver?
Done
https://review.coreboot.org/c/coreboot/+/81774/comment/b114bd62_1b6b2736 :
PS18, Line 9: Added
Add
Done
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/81774/comment/2cca3785_8f5609d9 :
PS18, Line 5: select DRIVERS_I2C_RT5645
Please reorder.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81774?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I093be6a3e357aae389fcbe8291a9701c40b62e15
Gerrit-Change-Number: 81774
Gerrit-PatchSet: 19
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 18 Apr 2024 02:02:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment