Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32061 )
Change subject: google/oak: Delete rowan ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
LGTM after making Jenkins happy.
If you remove it here, please also send a CL to depthcharge.
https://review.coreboot.org/#/c/32061/1/src/mainboard/google/oak/Kconfig File src/mainboard/google/oak/Kconfig:
https://review.coreboot.org/#/c/32061/1/src/mainboard/google/oak/Kconfig@27 PS1, Line 27: config OAK_HAS_TPM2 I mean, really we could take out the whole TPM2 support out now because Rowan was the only board using it. But that's probably not worth the effort.
https://review.coreboot.org/#/c/32061/1/src/mainboard/google/oak/Kconfig.nam... File src/mainboard/google/oak/Kconfig.name:
https://review.coreboot.org/#/c/32061/1/src/mainboard/google/oak/Kconfig.nam... PS1, Line 15: Checkpatch wants you to delete one more line.
https://review.coreboot.org/#/c/32061/1/src/mainboard/google/oak/mainboard.c File src/mainboard/google/oak/mainboard.c:
https://review.coreboot.org/#/c/32061/1/src/mainboard/google/oak/mainboard.c... PS1, Line 236: nit: fix alignment?