Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Jianjun Wang. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62791 )
Change subject: soc/mediatek: Add chip config for setting PCIe controller data ......................................................................
Patch Set 2:
(7 comments)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/62791/comment/37276c15_8917ff01 PS2, Line 109: pcie_ctrl This global variable makes me wonder if putting the 'base' in the devicetree is the right decision. What do you think if we just write PCIE_REG_BASE here (each SoC needs to define PCIE_REG_BASE in its pcie.h)? Then the global coulud be removed.
https://review.coreboot.org/c/coreboot/+/62791/comment/250941c6_dd16bee5 PS2, Line 168: struct const
https://review.coreboot.org/c/coreboot/+/62791/comment/d12bc48c_daa1ba11 PS2, Line 170: (struct mtk_pcie_controller *) Why do we need to cast?
https://review.coreboot.org/c/coreboot/+/62791/comment/5e6f5f56_b85b2793 PS2, Line 182: struct mtk_pcie_controller *ctrl; : uintptr_t table; : : ctrl = (struct mtk_pcie_controller *)&config->pcie_controller; Same.
https://review.coreboot.org/c/coreboot/+/62791/comment/41bcc8eb_3cd2c1dd PS2, Line 208: (struct mtk_pcie_controller *) No need.
File src/soc/mediatek/mt8195/chip.h:
https://review.coreboot.org/c/coreboot/+/62791/comment/f63d3d77_a7ee4a3e PS2, Line 9: controller config or conf
https://review.coreboot.org/c/coreboot/+/62791/comment/261b23a5_5e2e3f36 PS2, Line 9: controller config