Attention is currently required from: Tim Wawrzynczak. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64837 )
Change subject: soc/intel/alderlake: Drop enable_bios_reset_cpl() function ......................................................................
soc/intel/alderlake: Drop enable_bios_reset_cpl() function
This patch drops enable_bios_reset_cpl() as FSP sets the BIOS Reset CPL before performing Graphics PM init (as part of FSP-S), hence, enable_bios_reset_cpl() function getting called inside systemagent.c is meaningless.
Also, drop 1ms delay after setting the BIOS reset CPL.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I87beb444d3910f212a5a627cb449031db6cae38d --- M src/soc/intel/alderlake/systemagent.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/64837/1
diff --git a/src/soc/intel/alderlake/systemagent.c b/src/soc/intel/alderlake/systemagent.c index 1bbd62a..bb58b75 100644 --- a/src/soc/intel/alderlake/systemagent.c +++ b/src/soc/intel/alderlake/systemagent.c @@ -62,11 +62,6 @@ /* Enable Power Aware Interrupt Routing */ enable_power_aware_intr();
- /* Enable BIOS Reset CPL */ - enable_bios_reset_cpl(); - - /* Configure turbo power limits 1ms after reset complete bit */ - mdelay(1); config = config_of_soc();
/* Get System Agent PCI ID */