Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43672 )
Change subject: smbios: Add Type19 ......................................................................
Patch Set 1:
(2 comments)
Patch Set 1:
This is what I get on Asrock B85M Pro4 with 2 DIMMs:
# dmidecode 3.2 Getting SMBIOS data from sysfs. SMBIOS 2.8 present.
Handle 0x000B, DMI type 19, 31 bytes Memory Array Mapped Address Starting Address: 0x00000000000 Ending Address: 0x000000003FF Range Size: 1 kB Physical Array Handle: 0x0000 Partition Width: 2
Here's what I get on stock BIOS on the Toshiba Satellite Pro L70-A (Haswell laptop) with two 8 GiB sticks:
# dmidecode 3.2 Getting SMBIOS data from sysfs. SMBIOS 2.7 present.
Handle 0x0032, DMI type 19, 31 bytes Memory Array Mapped Address Starting Address: 0x00000000000 Ending Address: 0x003FFFFFFFF Range Size: 16 GB Physical Array Handle: 0x002A Partition Width: 4
https://review.coreboot.org/c/coreboot/+/43672/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/43672/1/src/arch/x86/smbios.c@1098 PS1, Line 1098: You need to initialize starting_address and ending_address to 0xffffffff so that the extended values are used instead.
https://review.coreboot.org/c/coreboot/+/43672/1/src/arch/x86/smbios.c@1107 PS1, Line 1107: *
Hrm, not that... I think there's some problem with type sizes though. […]
This is correct.